gabknight commented 5 months ago

Quick description

PR #750 forgot to include the PTT options for the script scil_tracking_local.py (issue #952). This PR fixed the issue.

Type of change

Check the relevant options.

[x] New feature (non-breaking change which adds functionality)

Provide data, screenshots, command line to test (if relevant)

scil_tracking_local.py disco/fODF.nii.gz disco/DiSCo1_ROIs.nii.gz disco/mask.nii.gz scil_test2.tck --step 0.2 --theta 20 --npv 1 --algo ptt --sphere repulsion724 -f --probe_quality 5 --probe_length 2

Checklist

[x] My code follows the style guidelines of this project (run autopep8)
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.18%. Comparing base (1996cc8) to head (8d72832). Report is 1 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #976 +/- ## ========================================== + Coverage 68.15% 68.18% +0.03% ========================================== Files 399 399 Lines 21365 21366 +1 Branches 3229 3229 ========================================== + Hits 14561 14569 +8 + Misses 5500 5493 -7 Partials 1304 1304 ``` | [Components](https://app.codecov.io/gh/scilus/scilpy/pull/976/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | Coverage Δ | | |---|---|---| | [Scripts](https://app.codecov.io/gh/scilus/scilpy/pull/976/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `69.20% <100.00%> (+<0.01%)` | :arrow_up: | | [Library](https://app.codecov.io/gh/scilus/scilpy/pull/976/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `66.65% <100.00%> (+0.08%)` | :arrow_up: |

pep8speaks commented 5 months ago

Hello @gabknight, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

scilus / scilpy

NF - add PTT options to the local tracking script #976

Quick description

Type of change

Provide data, screenshots, command line to test (if relevant)

Checklist

Codecov Report

Comment last updated at 2024-04-17 17:16:17 UTC