frheault commented 2 months ago

Quick description

New script to generate a HDF5 in the same style as for connectomics from a list of TRKs.

(Tests for the script will come this week)

...

Type of change

Check the relevant options.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

[x] My code follows the style guidelines of this project (run autopep8)
[ ] I added relevant citations to scripts, modules and functions docstrings and descriptions
[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I moved all functions from the script file (except the argparser and main) to scilpy modules
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

pep8speaks commented 2 months ago

Hello @frheault, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-06-18 16:59:53 UTC

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 83.01887% with 9 lines in your changes missing coverage. Please review.

Project coverage is 68.31%. Comparing base (3191a0b) to head (05b09c7). Report is 25 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #985 +/- ## ========================================== + Coverage 68.14% 68.31% +0.17% ========================================== Files 419 420 +1 Lines 21369 21455 +86 Branches 3216 3220 +4 ========================================== + Hits 14561 14658 +97 + Misses 5533 5531 -2 + Partials 1275 1266 -9 ``` | [Components](https://app.codecov.io/gh/scilus/scilpy/pull/985/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | Coverage Δ | | |---|---|---| | [Scripts](https://app.codecov.io/gh/scilus/scilpy/pull/985/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `69.29% <78.18%> (+0.15%)` | :arrow_up: | | [Library](https://app.codecov.io/gh/scilus/scilpy/pull/985/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `66.91% <76.33%> (+0.24%)` | :arrow_up: |

EmmaRenauld commented 1 month ago