scilus / scilpy

The Sherbrooke Connectivity Imaging Lab (SCIL) Python dMRI processing toolbox
Other
54 stars 59 forks source link

Fix verifications in volume_resample #986

Closed EmmaRenauld closed 2 months ago

EmmaRenauld commented 2 months ago

Reverted recent change in scil_volume_resample, that input image and ref had to be compatible: not here! Ref is the reference to which to reshape.

pep8speaks commented 2 months ago

Hello @EmmaRenauld, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-04-26 19:05:40 UTC
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 53.84615% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 68.07%. Comparing base (9b79ea4) to head (3452087). Report is 5 commits behind head on master.

:exclamation: Current head 3452087 differs from pull request most recent head 78fbd20. Consider uploading reports for the commit 78fbd20 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #986 +/- ## ========================================== + Coverage 68.01% 68.07% +0.06% ========================================== Files 419 419 Lines 21567 21577 +10 Branches 3241 3245 +4 ========================================== + Hits 14668 14688 +20 + Misses 5608 5601 -7 + Partials 1291 1288 -3 ``` | [Components](https://app.codecov.io/gh/scilus/scilpy/pull/986/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | Coverage Δ | | |---|---|---| | [Scripts](https://app.codecov.io/gh/scilus/scilpy/pull/986/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `68.96% <71.42%> (-0.01%)` | :arrow_down: | | [Library](https://app.codecov.io/gh/scilus/scilpy/pull/986/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `66.72% <47.36%> (+0.15%)` | :arrow_up: |