scimma / blast

Django web app for the automatic characterization of supernova hosts
MIT License
1 stars 2 forks source link

Djones sv tests #170

Closed djones1040 closed 1 year ago

djones1040 commented 1 year ago

Fixes # .

Description of the Change

fixes that improve the reliability of photometry. A couple bugs in the previous PR where the correct Aperture object was not being found. Image cutout downloads modify the calibration if the pixel size is not correct, so fixed some of the fixture info. Modified serializer to include is_validated flag for photometry. Local aperture size in kpc not arcsec. Fixed #172 .

Checklist

Please check all that apply to your proposed changes

Additional context

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 74.01% and project coverage change: +5.29 :tada:

Comparison is base (be13a29) 65.63% compared to head (d82b81f) 70.93%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #170 +/- ## ========================================== + Coverage 65.63% 70.93% +5.29% ========================================== Files 24 24 Lines 1711 1868 +157 ========================================== + Hits 1123 1325 +202 + Misses 588 543 -45 ``` | [Impacted Files](https://codecov.io/gh/astrophpeter/blast/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter) | Coverage Δ | | |---|---|---| | [app/host/prospector.py](https://codecov.io/gh/astrophpeter/blast/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter#diff-YXBwL2hvc3QvcHJvc3BlY3Rvci5weQ==) | `28.73% <22.22%> (+0.34%)` | :arrow_up: | | [app/host/transient\_tasks.py](https://codecov.io/gh/astrophpeter/blast/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter#diff-YXBwL2hvc3QvdHJhbnNpZW50X3Rhc2tzLnB5) | `73.97% <60.00%> (+9.09%)` | :arrow_up: | | [app/host/host\_utils.py](https://codecov.io/gh/astrophpeter/blast/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter#diff-YXBwL2hvc3QvaG9zdF91dGlscy5weQ==) | `68.22% <66.66%> (+14.82%)` | :arrow_up: | | [app/host/ghost.py](https://codecov.io/gh/astrophpeter/blast/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter#diff-YXBwL2hvc3QvZ2hvc3QucHk=) | `90.00% <80.00%> (+36.66%)` | :arrow_up: | | [app/host/cutouts.py](https://codecov.io/gh/astrophpeter/blast/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter#diff-YXBwL2hvc3QvY3V0b3V0cy5weQ==) | `69.46% <80.18%> (+42.04%)` | :arrow_up: | | [app/api/serializers.py](https://codecov.io/gh/astrophpeter/blast/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter#diff-YXBwL2FwaS9zZXJpYWxpemVycy5weQ==) | `100.00% <100.00%> (ø)` | | | [app/host/models.py](https://codecov.io/gh/astrophpeter/blast/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter#diff-YXBwL2hvc3QvbW9kZWxzLnB5) | `92.20% <100.00%> (+1.33%)` | :arrow_up: | | [app/host/plotting\_utils.py](https://codecov.io/gh/astrophpeter/blast/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter#diff-YXBwL2hvc3QvcGxvdHRpbmdfdXRpbHMucHk=) | `61.74% <100.00%> (+1.05%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://codecov.io/gh/astrophpeter/blast/pull/170/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Peter)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

astrophpeter commented 1 year ago

readthedocs seems to be complaining with pycurl-7.45.2, what is it needed for?

astrophpeter commented 1 year ago

Overriding CI