scimma / blast

Django web app for the automatic characterization of supernova hosts
MIT License
1 stars 2 forks source link

More intialization script improvements and idempotency, Django fixtures improvements, updated docs #194

Closed manning-ncsa closed 7 months ago

manning-ncsa commented 7 months ago

Description of the Change

Many improvements and bug fixes. More intialization script improvements supporting true idempotency, including Django fixtures improvements to avoid redundant database table rows being generated. Updated developer docs. More capitalization fixes for Blast branding. Improvements to run and stop scripts. See commit messages for more details.

Checklist

Please check all that apply to your proposed changes

Additional context

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.62%. Comparing base (b64b805) to head (3dd4bfc). Report is 8 commits behind head on main.

:exclamation: Current head 3dd4bfc differs from pull request most recent head 45e4690. Consider uploading reports for the commit 45e4690 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #194 +/- ## ======================================= Coverage 53.62% 53.62% ======================================= Files 28 28 Lines 3355 3355 ======================================= Hits 1799 1799 Misses 1556 1556 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

manning-ncsa commented 7 months ago

The production instance has been running commit 3dd4bfc overnight and is functioning properly.

The CodeFactor check issues are about the usage of "bare except" statements in the initialization script. I am using these because it was not obvious how to properly handle the ValidationError associated with the Django fixture loaddata operation failing due to "duplicate entry" errors. This could be a new issue to tackle at a later date.

@djones1040 I recommend merging this after your own tests of the local dev environment. Please review the related documentation updates.