scimma / blast

Django web app for the automatic characterization of supernova hosts
MIT License
1 stars 2 forks source link

Address formatting issues #213

Closed manning-ncsa closed 6 months ago

manning-ncsa commented 6 months ago

Fixes #212

manning-ncsa commented 6 months ago

There is a conflict between Black and reorder-python-imports starting with Black v24 related to spacing. One wants to insert blank lines and the other wants to remove them; hence the pre-commit workflow will always fail. I recommend we downgrade to Black v23 until this is fixed or there is a workaround. To do that, however, we need to disable the pre-commit autoupdate.

manning-ncsa commented 6 months ago

The closest config option I can find is at pre-commit.ci, where it says autoupdate_schedule can be set to 'quarterly':

(optional, default: 'weekly') control when the autoupdate runs, possible values: 'weekly', 'monthly', 'quarterly'.

manning-ncsa commented 6 months ago

The codecov/codecov-action GitHub action exits without action when a coverage.xml file is missing. Until we find a way to run the unit test script in the GitHub actions workflow, the entire continuous-integration.yml workflow file is impotent so I removed it for now.