Add a configurable prefix to the names of all AWS secrets.

scimma / scimma-admin

Administrative web UI for SCIMMA backend resources

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

Add a configurable prefix to the names of all AWS secrets. #31

Closed cnweaver closed 3 years ago

cnweaver commented 3 years ago

This makes it practical to run two independent instances using variables in the same secretsmanager namespace.

It would have been an option to bake use of SECRET_NAME_PREFIX into the get_secret function; I eleceted not to do this as I preferred to have it more obvious where the names themselves appear that another component is added to them, but this trades off against the possibility that we will forget to include it if we add another variable, so I could have my mind changed.

cnweaver commented 3 years ago

I considered doing it the other way, and it's not that much harder, so I'm going to do that and make a new PR.