search

scimusmn / multiplayer-phone-game

Reusable game template in which visitors use their smartphone as a controller.
0 stars 0 forks source link

ua-parser is insecure #35

Closed bryankennedy closed 5 years ago

bryankennedy commented 5 years ago

The version of ua-parser we're importing has a security issue. Upgrade to fix.

bryankennedy commented 5 years ago

I got this wrong, the bug is still active: https://www.npmjs.com/advisories/316

We need to switch to another package to address this. I'll look at whether we can easily switch useragent

bryankennedy commented 5 years ago

@tnordberg I switched to a different module to display the UA info in the console. Take a look and make sure that the data is showing up correctly for you. If this works, please close the issue.

tnordberg commented 5 years ago

Thanks @bryankennedy, I tested and the user agent data is still coming through as expected. Closing.