scinfu / SwiftSoup

SwiftSoup: Pure Swift HTML Parser, with best of DOM, CSS, and jquery (Supports Linux, iOS, Mac, tvOS, watchOS)
https://scinfu.github.io/SwiftSoup/
MIT License
4.53k stars 345 forks source link

Dont work with Xcode 11 beta 5 and Carthage #120

Closed catluc closed 5 years ago

catluc commented 5 years ago

The carthage update --platform ios process in Carthage ver. 0.33.0 gets stucked with SwiftSoup 2.2.0. I dont know if this issue is SwiftSoup side or Carthage. It will be nice if you can provide some feedback about this issue?

funkenstrahlen commented 5 years ago

This is very likely a duplicate of #116

catluc commented 5 years ago

This is very likely a duplicate of #116

Ok thanks, i just reported this to Apple, hope they fix their stuff

catluc commented 5 years ago

This is very likely a duplicate of #116

One question: ¿Do you know if is possible to generate the framework in Xcode11 beta for SwiftSoup manually?, I tried to do it manually but it only generates the architectures for simulators or for devices but never for both toghether

Jeehut commented 5 years ago

Hey everyone, while it's not a real fix, as noted by @Igor-Palaguta in #116 a workaround is to set the SWIFT_OPTIMIZATION_LEVEL to -Onone for release builds. I've done exactly that in my fork, feel free to use it's master branch instead of this original repo when installing via Carthage or Accio. Unfortunately, it seems the will not merge it, as can be seen by my long term open PR https://github.com/scinfu/SwiftSoup/pull/117.

In Accio, use this entry instead:

.package(url: "https://github.com/Dschee/SwiftSoup.git", .branch("master")),

In Carthage, use that:

github "Dschee/SwiftSoup" "master"
catluc commented 5 years ago

Hey everyone, while it's not a real fix, as noted by @Igor-Palaguta in #116 a workaround is to set the SWIFT_OPTIMIZATION_LEVEL to -Onone for release builds. I've done exactly that in my fork, feel free to use it's master branch instead of this original repo when installing via Carthage or Accio. Unfortunately, it seems the will not merge it, as can be seen by my long term open PR #117.

In Accio, use this entry instead:

.package(url: "https://github.com/Dschee/SwiftSoup.git", .branch("master")),

In Carthage, use that:

github "Dschee/SwiftSoup" "master"

Did u try this out in the last Xcode 11 beta 6? and what are the implications to set Swift Optimization Level to -0none?

Jeehut commented 5 years ago

Yes, I did, it's working and is still needed. As for -Onone, well, it runs slower during runtime. I'm not aware of other implications.

catluc commented 5 years ago

Yes, I did, it's working and is still needed. As for -Onone, well, it runs slower during runtime. I'm not aware of other implications.

Thanks, but i just checked this out, and it´s still getting stucked on Carthage on same process and same error...... with Xcode 11 beta 6

Error:

SwiftSoup.build/Release-iphoneos/SwiftSoup-iOS.build/Objects-normal/armv7/ParseError.bc

Jeehut commented 5 years ago

Well, it's working for me though ... weird. I'm running Xcode 11 beta 6 on Mojave, maybe that's it?

kylebrowning commented 5 years ago

Stuck for me, Xcode 11 Beta 7

rubenvde commented 5 years ago

It's still stuck on the Xcode 11 GM :cold_sweat:. I tried @Dschee approach but without any luck

scinfu commented 5 years ago

Duplicate of #116