scinfu / SwiftSoup

SwiftSoup: Pure Swift HTML Parser, with best of DOM, CSS, and jquery (Supports Linux, iOS, Mac, tvOS, watchOS)
https://scinfu.github.io/SwiftSoup/
MIT License
4.53k stars 345 forks source link

"SwiftSoup" Sceme in Example.workspace Gets Built with Carthage #122

Closed nicolas-miari closed 5 years ago

nicolas-miari commented 5 years ago

The "SwiftSoup" scheme in the "Example" workspace is marked as "shared", and thus gets automatically built with building Carthage dependencies, making the (already long) build unnecessarily longer.

Screen Shot 2019-09-11 at 13 56 25 Screen Shot 2019-09-11 at 13 56 52

...or is it needed for CI purposes?

scinfu commented 5 years ago

Did you open Example/Example.xcworkspace ? It's not flagged shared.

...or is it needed for CI purposes?

I'm removing it, let know if problem persists

scinfu commented 5 years ago

Fixed in 2.2.1

Can you try and let me know if the change make some problem?

nicolas-miari commented 5 years ago

@scinfu Thanks, I’ll check it as soon as I get to work on Tuesday.

aehlke commented 5 years ago

I'm experiencing this still:

*** Checking out SwiftSoup at "2.2.1"
[...]
*** Building scheme "SwiftSoup-iOS" in SwiftSoup.xcodeproj
*** Building scheme "SwiftSoup" in Example.xcworkspace

Xcode 11

aehlke commented 5 years ago

It looks like it hangs at this point, blocking me from using SwiftSoup. Swift consumes all my CPU building this step but after a couple attempts of letting it run for tens of minutes it never finishes. Could be that I need to wait longer but I believe it ran for more than a half hour, seemingly stuck at that point.

For now I've forked the project and simply deleted the Example folder and now it's building as a dependency, for those who this may help: https://github.com/aehlke/SwiftSoup

nicolas-miari commented 5 years ago

@scinfu It seems to be working now, for me at least. Using:

carthage update SwiftSoup --platform iOS

I get:

Screen Shot 2019-09-24 at 12 15 17

I also tried updating all dependencies with $ carthage update --platform iOS (just to be sure), and Example.xcworkspace isn't built.

Thank you.