Many tests are failing due to self-closing tags in HTML

scinfu / SwiftSoup

SwiftSoup: Pure Swift HTML Parser, with best of DOM, CSS, and jquery (Supports Linux, iOS, Mac, tvOS, watchOS)

https://scinfu.github.io/SwiftSoup/

MIT License

4.52k stars 345 forks source link

Many tests are failing due to self-closing tags in HTML #260

Open Aloisius opened 9 months ago

Aloisius commented 9 months ago

It looks like #250 started self-closing void tags like <img> tags which broke a whole bunch of tests.

Self-closing tags (<tag />) do not exist in HTML. While it's explicitly ignored in HTML5, it's technically invalid in HTML4 though in practice parsers ignore it. Either the change should be reverted or all the tests should be fixed.

Perhaps a GitHub Action should be setup to test builds during pull requests/push?

scinfu commented 8 months ago

At this moment i do not have time to make changes until 7/2024