scinfu / SwiftSoup

SwiftSoup: Pure Swift HTML Parser, with best of DOM, CSS, and jquery (Supports Linux, iOS, Mac, tvOS, watchOS)
https://scinfu.github.io/SwiftSoup/
MIT License
4.52k stars 345 forks source link

Privacy Manifest #262

Closed cendolinside123 closed 7 months ago

cendolinside123 commented 8 months ago

From Apple docs :

Starting in spring 2024, you must include the privacy manifest for any SDK listed below when you submit new apps in App Store Connect that include those SDKs, or when you submit an app update that adds one of the listed SDKs as part of the update. Signatures are also required in these cases where the listed SDKs are used as binary dependencies.

Could you please add a privacy manifest for this library?

scinfu commented 8 months ago

Do you know where can i find an example? This library do not use any data.

cendolinside123 commented 8 months ago

Do you know where can i find an example? This library do not use any data.

Actualy I don't realy know what data need or what apple API that use on this app.

Some Privacy manifest example baybe can be seen on https://github.com/cendolinside123/IGListKit/tree/Jan/Privacy-Manifest-Support-Main-Branch

cendolinside123 commented 8 months ago

and you can check this one; https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api

cendolinside123 commented 7 months ago

we have updated to the latest pod with SwiftSoup (2.7.1). we can see the Privacy Manifest file. The root case is declared wrong format. So we get this error when we generate the privacy report.

Screenshot 2024-03-04 at 12 15 08 in the afternoon

Privacy Manifest is must change to like this /*

NSPrivacyTracking NSPrivacyTrackingDomains NSPrivacyCollectedDataTypes NSPrivacyAccessedAPITypes */ So the issues is fixed after change like above. COuld you update the code for that?

Screenshot 2024-03-04 at 12 55 03

like this one?

takmorgaming commented 7 months ago

update to like this Screenshot 2024-03-04 at 12 59 28 in the afternoon

cendolinside123 commented 7 months ago

takmorgaming

I see, look like XML issue when I generate value

cendolinside123 commented 7 months ago

update to like this Screenshot 2024-03-04 at 12 59 28 in the afternoon

thanks for the report, already do pull request. Waiting the owner to approve @scinfu

kapitoshka438 commented 7 months ago

@scinfu I may be wrong but you don't need to add a privacy manifest at all if your library doesn't collect any tracking or non-tracking data and doesn't use any of APIs needed to be describes in the manifest. In other words, if your manifest is empty just don't add it. The latest version 2.7.1 has invalid manifest and I would recommend to just remove it and release the fix.

Снимок экрана 2024-03-15 в 19 53 00

Or just review and approve this pr https://github.com/scinfu/SwiftSoup/pull/264 it makes it work

scinfu commented 7 months ago

released in 2.7.2 thank you

radu2lupu commented 1 month ago

I got the following error back from Apple. I am on 2.7.5 version of the library.

image
jonasman commented 1 month ago

Got the same today