Apparent regression in 2.7.3

scinfu / SwiftSoup

SwiftSoup: Pure Swift HTML Parser, with best of DOM, CSS, and jquery (Supports Linux, iOS, Mac, tvOS, watchOS)

https://scinfu.github.io/SwiftSoup/

MIT License

4.52k stars 345 forks source link

Apparent regression in 2.7.3 #277

Closed DD-P closed 2 months ago

DD-P commented 2 months ago

HTML with Javascript containing CDATA and '&&' hangs on parsing. This first occurs with commit fc06146aa4231a11c5c0f1976a800992566e6e7e

A test case modified from here is

import SwiftSoup
import XCTest

class SwiftSoupTests: XCTestCase {
    func testJavaScriptWithCDATA() throws {
        let html = """
            <!DOCTYPE html>
            <html>
            <body>

            <h1>JavaScript Comparison</h1>
            <h2>The && Operator (Logical AND)</h2>
            <p>The && operator returns true if both expressions are true, otherwise it returns false.</p>

            <p id="demo"></p>

            <script>
            <!--//--><![CDATA[//><!--
            let x = 6;
            let y = 3;

            document.getElementById("demo").innerHTML = 
            (x < 10 && y > 1) + "<br>" + 
            (x < 10 && y < 1);
            //--><!]]>
            </script>

            </body>
            </html>
        """
        _ = try SwiftSoup.parse(html)
    }
}