Swift 4.2 and Xcode 10 support

scinfu / SwiftSoup

SwiftSoup: Pure Swift HTML Parser, with best of DOM, CSS, and jquery (Supports Linux, iOS, Mac, tvOS, watchOS)

https://scinfu.github.io/SwiftSoup/

MIT License

4.53k stars 345 forks source link

Swift 4.2 and Xcode 10 support #97

Closed fassko closed 6 years ago

fassko commented 6 years ago

warnings by compiler
convert Example project to Swift 4.2 and Xcode 10
bumped version in podspec

Need to use Cocoapods beta because it fails with current version.

TODO: Set up a tag for older Swift support (or a branch?)

fassko commented 6 years ago

@scinfu Can you tell what is happening in docker ? I'm not so familiar with that.

scinfu commented 6 years ago

The error was error: package at '/package' requires a minimum Swift tools version of 4.2.0 (currently 4.0.0), the error was generated when you changed Docker file file from RUN swift package tools-version --set 4.0 to RUN swift package tools-version --set 4.2. tools version 4.2 do not exist, the highest level is currently is 4.1, which is compatible with 4.0 and 4.2 but do not work.

I merged manually your request to pod 1.7.4 version. Thank you for your help.

fassko commented 6 years ago

@scinfu Thank you for clearing this out. I think I need to set up linux builds for one of my libraries as well with docker. And thank you for creating this library, I'm using it in many of my apps. :) 👍

scinfu commented 6 years ago

@fassko I think Travis-Ci is better. I added Docker just to learn how to use it.