search

scio-labs / use-inkathon

Typesafe React hooks and utility functions that simplify the process of working with Substrate-based networks and ink! smart contracts.
https://inkathon.xyz
GNU General Public License v3.0
51 stars 15 forks source link

feat: Add support Nightly Connect #37

Closed Pawel-Szydlo closed 11 months ago

changeset-bot[bot] commented 11 months ago

⚠️ No Changeset found

Latest commit: 49cd45642ae08ea46df0d5a632f9aebd53353aa3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

wottpal commented 11 months ago

Thanks for rebasing/merging @Pawel-Szydlo! Can you remove the version modifications in the package.json as well? Current one from main is "version": "0.2.0". – This is done automatically by CI/Workflow via changeset.

Try to test it today!

Pawel-Szydlo commented 11 months ago

ok, I have corrected it.

Pawel-Szydlo commented 11 months ago

One additional thing I would like to achieve is make the dependency @nightlylabs/wallet-selector-polkadot optional, and leave the choice to the dApp developer whether to use it or not. Also, this library is used by more than just Aleph Zero users which could lead to confusions for them. How could we achieve this?

Practically, this is already a universal selector because it detects wallets that are injected into web3. Soon it will be more universal (I think about 2-3 weeks)