scionproto / scion

SCION Internet Architecture
https://scion.org
Apache License 2.0
392 stars 160 forks source link

Go: rework mock generation #2960

Closed kormat closed 4 years ago

kormat commented 5 years ago

The use of gomocks in our codebase currently has the following issues:

Proposed fix:

kormat commented 5 years ago

Building mockgen with bazel fails because our version of rules_go pulls in a broken version of org_golang_x_tools (it predates https://github.com/golang/tools/commit/202502a5a9245830b5ec7b877e26b67760da8e67). The minimum version of rules_go to fix this seems to be 0.19.0.

kormat commented 4 years ago

Building mockgen with bazel fails with the updated rules_go because... it pulls in a newer version of org_golang_x_tools which has the same problem as the old version, just in a different file: https://github.com/golang/tools/commit/eec4c98bf5a6a9765c9de84cf61e447130fe8e54#diff-1910375731a87c0dea421568450908cc is the fix.