scionproto / scion

SCION Internet Architecture
https://scion.org
Apache License 2.0
381 stars 160 forks source link

router: factor out platform-dependent underlay conn flags #4507

Closed marcfrei closed 5 months ago

marcfrei commented 5 months ago

The use of the platform-dependent flag syscall.MSG_WAITFORONE prevents building the router on platforms other than Linux. This change isolates this dependency. Behavior on non-Linux platforms will be less efficient but still semantically correct because ReadBatch will only read a single message on those platforms anyway.

Together with the previous PR #4499 and the dispatcher removal PR #4344 this set of changes will, e.g., enable running local development topologies on platforms other than Linux.

Fixes #4046.

matzf commented 5 months ago

This change is Reviewable