scionproto / scion

SCION Internet Architecture
https://www.scion-architecture.net/
Apache License 2.0
369 stars 156 forks source link

ci: fix build for openwrt package, enable setting version from env var #4523

Closed matzf closed 1 month ago

matzf commented 1 month ago

Fix handling of release version (e.g. "0.11.0") in openwrt package build. Was only working for intermediate versions, like "0.10.0-32-asdlkjslka".

Fix variable interpolation issue for package builds; need to use $${version} to ensure interpolation of this variable at "runtime" with bash; otherwise buildkite attempts to interpolate with when creating the pipeline jobs. See https://buildkite.com/docs/pipelines/environment-variables#runtime-variable-interpolation.

Allow overwriting the version used for the builds consistently. Previously there was an envar GIT_VERSION that could do this partially. Renamed to SCION_VERSION and supported now also fully for the package builds. Setting this variable in buildkite pipelines should now allow, for example, building release builds before explicitly tagging the release.

matzf commented 1 month ago

This change is Reviewable