search

scipion-em / scipion-em-aretomo

Plugin to use AreTomo within the Scipion framework
GNU General Public License v3.0
2 stars 0 forks source link

Generate CTF Tomoseries ? #56

Closed pconesa closed 8 months ago

pconesa commented 9 months ago

New aretomo generates cistem files..... shouldn't we register a set of CTFTomoseries as output or aretomo?

JorMaister commented 9 months ago

Yes, we should. Indeed, The problem found here is that the CTF generated is of the size of the TS without considering the excluded tilt images (if there are any). To be coherent with the data model (binary file size does not change, storing the excluded views as an Enable field in the metadata), it should be necessary to add the missing CTF lines in the required position (based on the exclusion indices) so that the sizes match. It'd be just the same as when tilt images are excluded for the TS alignment, adding the corresponding registries with the rotation angle and shifts equal to zero.

@azazellochg, do you want to take this task? If you're overloaded or something, I can do it myself.

azazellochg commented 9 months ago

the problem is imho is that every few versions the output format of this program changes. I don't want this task, @JorMaister please go ahead, I'm happy to review more PRs :)

JorMaister commented 9 months ago

Ok, I'll assign it to myself, @azazellochg. Let's see if they finally keep the format more stable.