search

scipion-em / scipion-em-aretomo

Plugin to use AreTomo within the Scipion framework
GNU General Public License v3.0
2 stars 0 forks source link

Jj remove decorator #81

Closed JorMaister closed 4 months ago

azazellochg commented 4 months ago 
00011:     File "/public/EM/Scipion/scipion-dev/scipion-em-plugins/scipion-em-aretomo/aretomo/protocols/protocol_aretomo.py", line 543, in createOutputTs
00012:       newTomogram.setCtfCorrected(ts.ctfCorrected())
00013:   AttributeError: 'Tomogram' object has no attribute 'setCtfCorrected'
00014:   Protocol failed: 'Tomogram' object has no attribute 'setCtfCorrected'
JorMaister commented 4 months ago 
00011:     File "/public/EM/Scipion/scipion-dev/scipion-em-plugins/scipion-em-aretomo/aretomo/protocols/protocol_aretomo.py", line 543, in createOutputTs
00012:       newTomogram.setCtfCorrected(ts.ctfCorrected())
00013:   AttributeError: 'Tomogram' object has no attribute 'setCtfCorrected'
00014:   Protocol failed: 'Tomogram' object has no attribute 'setCtfCorrected'

Sorry, @azazellochg, The current changeset depends on the branch called jj_update_tcl of scipion-em-tomo, which adds the CTF corrected attribute to the Tomogram and SetOfTomograms objects among other changes, for those cases in which the tomograms have been reconstructed considering the CTF or from TS with the CTF corrected. It's in PR, but has not been merged yet.

azazellochg commented 4 months ago

Aah, I see. Should we bump tomo version in requirements.txt here then?

JorMaister commented 4 months ago

Yes, let me do it

azazellochg commented 4 months ago

It would be good in the future to split the steps code into smaller methods, it is indeed difficult to read like sonarcloud says

JorMaister commented 4 months ago

Agreed :D