Closed Vilax closed 1 year ago
Hi, I didn't look over this yet, all I noticed is odd even stuff will become like halfmaps property. Since you are changing the tomo plugin as well, I will need to go over this again once the base protocols work. Don't worry, I'll eventually merge this
On Mon, Mar 27, 2023, 19:12 Vilax @.***> wrote:
@azazellochg https://github.com/azazellochg , thanks for going over it so fast. No rush :)
Just adding to avoid overlapping, this modification depends on a refactorization in protocol_ts_motion in scipion-em-tomo plugin
See the PR here, just in case you are working on something similar:
https://github.com/scipion-em/scipion-em-tomo/pull/337
— Reply to this email directly, view it on GitHub https://github.com/scipion-em/scipion-em-motioncorr/pull/81#issuecomment-1485621942, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVBPJWDUHWBFPRQWWC4TY3W6HKBLANCNFSM6AAAAAAWJO3L5I . You are receiving this because you were mentioned.Message ID: @.***>
I'd change this to draft until is changes in tomo are released, so code doe not prevent the release of itself.
@azazellochg just checking the state of the refactorization before merging this PR
Hi, this cannot be merged before https://github.com/scipion-em/scipion-em-tomo/pull/337
hahaha, then, I think we were waiting in a kind of circular waiting list. Let's go for that PR first. Thanks @azazellochg Grigory
:) otherwise, my refactoring is done. If core tomo PR is merged, I will check odd/even here and merge this week-end.
Sorry, this won't be merged yet as I have started a big refactoring