scipion-em / scipion-em-sphire

Plugin to use Sphire programs within the Scipion framework
GNU General Public License v3.0
0 stars 1 forks source link

Jmrt devel #116

Closed delarosatrevin closed 5 months ago

delarosatrevin commented 6 months ago

Main changes:

azazellochg commented 6 months ago

thank you @delarosatrevin ! I'll have a look

azazellochg commented 6 months ago

All good, however the tasks protocol does not work:

00010:     File "/home/gsharov/soft/scipion-em-plugins/scipion-em-sphire/sphire/protocols/protocol_cryolo_picking_tasks.py", line 94, in <listcomp>
00011:       blacklist = [mic.clone() for mic in inputMics if mic.getObjId() in micIds]
00012:   NameError: free variable 'micIds' referenced before assignment in enclosing scope
delarosatrevin commented 6 months ago

I will have a look, maybe something no committed by mistake

azazellochg commented 6 months ago

Also I couldn't find where you create micrographs.json

On Sun, 28 Apr 2024, 00:35 Jose Miguel de la Rosa Trevin, < @.***> wrote:

I will have a look, maybe something no committed by mistake

— Reply to this email directly, view it on GitHub https://github.com/scipion-em/scipion-em-sphire/pull/116#issuecomment-2081247329, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVBPJWKAE3H27USNL7ZRY3Y7QY4ZAVCNFSM6AAAAABGTBXFFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBRGI2DOMZSHE . You are receiving this because your review was requested.Message ID: @.***>

delarosatrevin commented 6 months ago

I fixed the mentioned issues