scipion-em / scipion-em-sphire

Plugin to use Sphire programs within the Scipion framework
GNU General Public License v3.0
0 stars 1 forks source link

Unmatching model names #123

Closed fede-pe closed 3 months ago

fede-pe commented 3 months ago

When running 'scipion installb cryolo_model'

the dowloaded model is saved as: cryolo_model-202005_nn_N63_c17/gmodel_phosnet_202005_nn_N63_c17.h5

while the expected file name by the protocol is: cryolo_model-202005_N63_c17/gmodel_phosnet_202005_N63_c17.h5

Linking the file to a renamed file and folder solved the issue.

azazellochg commented 3 months ago

These are different models! "nn" is janni-denoised

azazellochg commented 3 months ago

installb downloads both models: https://github.com/scipion-em/scipion-em-sphire/blob/master/sphire/__init__.py#L152 by default

fede-pe commented 3 months ago

scipion3 installb cryolo_model

is only installing cryolo_model-202005_nn_N63_c17 to me

azazellochg commented 3 months ago

ok, I'll have a look. Thanks!

azazellochg commented 3 months ago

I see the problem. Installp should install both models with the plugin, since they both have default=True flag. However, installb will install only one of them, because both binaries are called "cryolo_model" and the difference is the "version". I don't see any workaround for this without changing model/vars names that will break backwards compatibility.

fede-pe commented 3 months ago

I see, is there a manual way to download the models from terminal (wget or similar)? I am just missing the models I would rather not reinstall the plugin

azazellochg commented 3 months ago

of course, "scipion3 installb cryolo_model-202005_N63_c17" will do it

fede-pe commented 3 months ago

great! thanks grigory