scipion-em / scipion-pyworkflow

Underlying pyworkflow module for the Scipion framework
GNU General Public License v3.0
5 stars 5 forks source link

Misleading label propagation #488

Open delarosatrevin opened 7 months ago

delarosatrevin commented 7 months ago

I have found another behavior (new to me) that, in my opinion, is a bit misleading and confusing I have run an abnitio job in CS from Scipion, then selected one of the volumes and ran xmipp preprocess (flip hand) Both the selection (where I choose 'vol2' as label and the preprocess operation keep propagating the 'cryospac abinitio ... ' label I don't know if that might be useful in other scenarios, but then searching for a volume produced by xmipp preprocess with 'cryosparc abnitio ...' label is quite confusing

pconesa commented 7 months ago

I see, the motivaion of this was the following: When you have volumes, mainly in initial volume methods.....we have setOfvolumes....if you use volume alignment protocol or a join set.... those volue are joined and then it was not possible or easy to identify which volume was which.

Maybe, the xmipp postprocess should update the label in this case? Or prefix it?

delarosatrevin commented 7 months ago

I would say it is the other way around. That align-volumes protocol should propagate it if not better label. But other protocols do not. I found it misleading in the subset case, where the users explicitly set a label (like in my case) but it is ignored and not shown in the search dialog.