search

scipopt / CSIP

Reduced and simplified C interface to SCIP
MIT License
15 stars 11 forks source link

just remove object, if any, when empty objective is given #41

Closed fserra closed 6 years ago

fserra commented 6 years ago

fixes https://github.com/SCIP-Interfaces/SCIP.jl/issues/67

rschwarz commented 6 years ago

Looks good!

fserra commented 6 years ago

oh, I forgot the test. The test you wrote is not testing the issue. Apparently, Julia always sets and objective an apparently, when there is no objective it passes an expression that looks like +() or something like that. that is a sum expression with no children, that is not the same as passing nothing at all (or not even calling the function).

Anyway, creating that in the CSIP side is absurd

rschwarz commented 6 years ago

Oh, well, I created a test in SCIP.jl, so it's covered that way.