scipopt / russcip

Rust interface for SCIP
https://crates.io/crates/russcip
Apache License 2.0
30 stars 10 forks source link

Added `set_obj_integral` Method #101

Closed CodingTil closed 11 months ago

CodingTil commented 11 months ago

See Issue https://github.com/scipopt/russcip/issues/95

cargo build runs through, as well as cargo fmt (at least for my code). I am unable to run cargo test at the moment, it currently says it cannot find libscip.8.0.dylib - seems unrelated to my code.


Changelog:

CodingTil commented 11 months ago

Update: Managed to get cargo test working. Test fails: [scip_prob.c:1547] ERROR: method is not callable in SCIP stage <0> I think see https://github.com/scipopt/scip/blob/beae291be2e4daf8cf581c2b703bd38c53dd5dcf/src/scip/scip_prob.c#L1509 - one cannot call it at the Unsolved Stage?

codecov[bot] commented 11 months ago

Codecov Report

Merging #101 (093957e) into main (1ffb0d1) will increase coverage by 0.06%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   91.29%   91.36%   +0.06%     
==========================================
  Files          13       13              
  Lines         804      810       +6     
==========================================
+ Hits          734      740       +6     
  Misses         70       70              
Files Changed Coverage Δ
src/model.rs 97.86% <100.00%> (+0.03%) :arrow_up:
src/scip.rs 98.21% <100.00%> (+0.01%) :arrow_up:
CodingTil commented 11 months ago

please don't forget to update the changelog

Oh, I realize now you meant CHANGELOG.md - will do that

mmghannam commented 11 months ago

Perfect, thanks again @CodingTil! Will merge right after the pipelines pass, looking forward to your next contribution :)