Closed KarelPeeters closed 11 months ago
Merging #115 (3e87e7e) into main (cc34f3d) will increase coverage by
0.35%
. The diff coverage is100.00%
.:exclamation: Current head 3e87e7e differs from pull request most recent head 693164a. Consider uploading reports for the commit 693164a to get more accurate results
@@ Coverage Diff @@
## main #115 +/- ##
==========================================
+ Coverage 74.61% 74.96% +0.35%
==========================================
Files 13 13
Lines 1729 1725 -4
==========================================
+ Hits 1290 1293 +3
+ Misses 439 432 -7
Files | Coverage Δ | |
---|---|---|
src/branchrule.rs | 93.88% <ø> (ø) |
|
src/heuristic.rs | 100.00% <ø> (ø) |
|
src/model.rs | 89.59% <100.00%> (+0.07%) |
:arrow_up: |
src/pricer.rs | 92.73% <ø> (ø) |
|
src/status.rs | 88.10% <100.00%> (ø) |
|
src/variable.rs | 81.82% <100.00%> (ø) |
Thanks a lot for your contribution! could you please also update the CHANGELOG.md
?
I added a new version (0.1.5) of scip-sys
with your change and updated the version number here.
I hope I added that to the right section of the changelog 😅 .
I hope I added that to the right section of the changelog 😅 .
Yeah, it's always a philosophical dilemma for me too 😄 Thanks again @KarelPeeters!
Thanks for the quick merges!
Fixes https://github.com/scipopt/russcip/issues/114, also has some other small improvements.
Depends on https://github.com/scipopt/scip-sys/pull/4 to actually fully build on windows, so maybe a version bump of the sys crate and a corresponding change in this
Cargo.toml
is necessary.