Closed mohammadfawaz closed 8 months ago
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
431132b
) 76.05% compared to head (9ab9b60
) 76.02%.
Files | Patch % | Lines |
---|---|---|
src/scip.rs | 50.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@mmghannam what do you suggest I do regarding the code coverage failures?
@mmghannam what do you suggest I do regarding the code coverage failures?
Well, they just failed because rustfmt
sperated a method call to 3 lines instead of 1, nothing to worry about. So in this case it's easy we just ignore it 😄
Thanks a lot @mohammadfawaz! This would improve the future contributions of this repo a whole lot! One thing I'm concerned about is the need to add this
#[allow(clippy::too_many_arguments)]
before some function definitions for which all arguments are necessary I believe and it bloats the repo a bit. Anyways I believe this does more good than harm in general.
Good point regarding the annoying annotation. We can instead add the following to Cargo.toml
:
[lints.clippy]
too_many_arguments = "allow"
I'll open a separate issue to track that.
When I was working on #120, I noticed that Clippy and
rustfmt
are not run in this project. I didn't run them in #120 to avoid polluting the PR but I thought I'd do them in a separate PR. Feel free to reject this but I've personally always found thatrustfmt
and Clippy highly improve the quality of the code in a Rust project.