search

scipopt / russcip

Rust interface for SCIP
https://crates.io/crates/russcip
Apache License 2.0
37 stars 11 forks source link

Add remaining branching results #61

Closed mmghannam closed 1 year ago

mmghannam commented 1 year ago

Support all result types mentioned in the section titled "Further information for the three execution methods" in https://www.scipopt.org/doc/html/BRANCH.php

matbesancon commented 1 year ago

What do you need to do to support them? It's mostly on the side of the plugin implementation no?

On Mon, May 8, 2023, 17:36 Mohammed Ghannam @.***> wrote:

Support all result types mentioned in the section titled "Further information for the three execution methods" in https://www.scipopt.org/doc/html/BRANCH.php

— Reply to this email directly, view it on GitHub https://github.com/scipopt/russcip/issues/61, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2FDMWT5BVJUIMIJ7XW4QLXFEHIFANCNFSM6AAAAAAX2DNXDI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

mmghannam commented 1 year ago

We'd need to add more variants for the BranchingResult enum to cover the missing cases, like SCIP_REDUCEDDOM for example.

matbesancon commented 1 year ago

I would probably just map the enums one to one

On Mon, May 8, 2023, 19:05 Mohammed Ghannam @.***> wrote:

We'd need to add more variants for the BranchingResult enum to cover the missing cases, like SCIP_REDUCEDDOM for example.

— Reply to this email directly, view it on GitHub https://github.com/scipopt/russcip/issues/61#issuecomment-1538734881, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2FDMS5K2TK3QFOJOAKZ23XFERWPANCNFSM6AAAAAAX2DNXDI . You are receiving this because you commented.Message ID: @.***>

mmghannam commented 1 year ago

Yes, that's the plan. I just created this issue that I don't forget :)