search

scipopt / scip-sys

Raw rust bindings to SCIP's C-API
https://crates.io/crates/scip-sys
2 stars 4 forks source link

Broken builds #21

Closed coffinsfcompute closed 2 weeks ago

coffinsfcompute commented 2 weeks ago

Hello,

I couldn't help but notice that https://github.com/scipopt/scip-sys/releases/tag/v0.1.9 was updated yesterday and broke Linux builds. We will probably just fork this internally, and self host a copy of the old zip file. If it would be possible in the future could you please not update artifacts without providing a new name, or version? Thank you. This also breaks deterministic builds, and any systems that checksum downloads to make sure that they haven't changed.

error: linking with `cc` failed: exit status: 1
  |
  = note: LC_ALL= --- INTENTIONALLY REMOVED FROM PASTE ---
  = note: /usr/bin/ld: /home/runner/work/target/debug/build/scip-sys-5c3d21e2535f9339/out/scip_install/lib/libscip.a(cons_cardinality.c.o): relocation R_X86_64_32 against `.LC1' can not be used when making a PIE object; recompile with -fPIE
          /usr/bin/ld: failed to set dynamic section sizes: bad value
          collect2: error: ld returned 1 exit status
mmghannam commented 2 weeks ago

I'm very sorry! I accidentally removed the shared libs when I updated them. You're totally right, should've added a new version. I updated it again to have the shared libs.

coffinsfcompute commented 2 weeks ago

Thank you so much for fixing this. I really appreciate it <3

mmghannam commented 2 weeks ago

Happy to! thank you for reporting it quickly and sorry again for the hassle.