search

scipopt / scip

SCIP - Solving Constraint Integer Programs
Other
393 stars 63 forks source link

cmake fixes #24

Closed Mizux closed 2 years ago

Mizux commented 2 years ago

various fixes needed after the merge of https://github.com/scipopt/scip/commit/ecbe3066ecfb572e75e3ed65145c7ccf5be185d6

  1. Using set(BLISS_TARGET "") thus cmake configure will take the DEFINED branch... https://github.com/scipopt/scip/blob/6da7b1df858dc863a0ee7ef13b5f182cdc18a6f7/src/CMakeLists.txt#L1043-L1053

  2. CMake TARGET properties don't have the CMAKE_ prefix which is only used when setting the default value, so the following TARGET properties are just ignored... https://github.com/scipopt/scip/blob/6da7b1df858dc863a0ee7ef13b5f182cdc18a6f7/src/CMakeLists.txt#L1093-L1095

please take a look at https://github.com/google/or-tools/issues/3454 for details

fschloesser commented 2 years ago

Thank you! I will add this to the internal repository to see if it passes ci and let you know

fschloesser commented 2 years ago

This looks good, I will add it to v80-bugfix and it should be visible tomorrow, thank you!