search

scipopt / soplex

Sequential object-oriented simPlex
Other
59 stars 18 forks source link

Allow flexible Boost versions #24

Closed AntoinePrv closed 6 months ago

ambros-gleixner commented 9 months ago

@ju-manns Can you comment here?

ju-manns commented 9 months ago

That change looks very sensible. I will create an internal merge request for that. Thank you!

AntoinePrv commented 9 months ago

@ju-manns Any update on this? If this is internally merged, could you cut a bugfix release to integrate the change?

leoneifler commented 6 months ago

Sorry that there has been no activity here for so long, I think it got lost in the no-one-feels-responsible limbo. I think this change just effectively removes the minimum version requirements, since it sets the minimum version to whatever version is available. Am I misunderstanding something here?

AntoinePrv commented 6 months ago

This file is templated and installed with Soplex. Currently, it tells Soplex users it need Boost 1.71.0, regardless of how it was built. But in fact Soplex users need to use the same Boost version than the one that was used at build time (the change with @ gets replaced by CMake when installing).

If there is specific version requirements on Boost, It should be states in CMakeLists.txt and the constraint would propagate here. But I would avoid setting upper bound (or exact version) as it makes packaging it harder.

leoneifler commented 6 months ago

Ah, now I understand, I did not see that your change was to the config file. This really is a necessary version requirement, and it is also stated in CMakeLists.txt. However, the two versions do not match and you are right that it should be propagated from `CMakeLists.txt