scipopt / soplex

Sequential object-oriented simPlex
Other
59 stars 18 forks source link

Get single or set of row's activity #33

Closed TendTo closed 5 months ago

TendTo commented 6 months ago

Major

Minor

leoneifler commented 6 months ago

Hi, thank you for submitting this PR. I will add some comments to the code.

Just so you know our current workflow: Once we think the code is good, I will cherry-pick your PR onto our internal GitLab, as that is where all of our CI runs (migrating fully to GitHub is planned, but the CI migration proves difficult). I will then close your PR, and the changes will be mirrored to GitHub (your commits will still be in your name, of course)

leoneifler commented 6 months ago

Could you add a CHANGELOG entry? Otherwise the PR looks good to me.

leoneifler commented 5 months ago

I will close this MR and move the commits over to our internal gitlab (our CI mostly runs there still so that makes this ugly workflow necessary). I will ping you once it appears here on GitHub.