search

scipp / chexus

Validate NeXus files
https://scipp.github.io/chexus/
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

Base review #1

Closed SimonHeybrock closed 1 year ago

SimonHeybrock commented 1 year ago

This code is already in main, I created a dummy branch for review.

There are certainly a number of things that won't work fully, for example shape handling with JSON (but there are no validators using shape currently). Testing is maybe a bit sparse compared to our usual projects, but since this is not a production library I hope we can live with fixing this as we go.

SimonHeybrock commented 1 year ago

Thanks for the comments @nvaytet, implemented in #2.