search

scipp / chexus

Validate NeXus files
https://scipp.github.io/chexus/
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

Add check for correct units in NXdisk_chopper #3

Closed SimonHeybrock closed 10 months ago

SimonHeybrock commented 12 months ago

I have seen some files with missing frequency units (or units '' instead of 'Hz').

jokasimr commented 11 months ago

What should happen if the unit is not 'Hz' do we raise or warn or replace it silently?

jl-wynen commented 11 months ago

Chexus can't replace the unit, only warn about it. Also, it just needs to a frequency, doesn't matter which one.

The loader in scippneutron used to assign Hz if there is no unit. But I just removed that.

jokasimr commented 11 months ago

~I have a PR for this, but I don't have permission to update the issue assignees field or push to the repo.~ Fixed now.