Use CI pre-commit action.

scipp / copier_template

Copier template for Scipp projects

BSD 3-Clause "New" or "Revised" License

2 stars 1 forks source link

Use CI pre-commit action. #120

Closed YooSunYoung closed 7 months ago

YooSunYoung commented 9 months ago

Fixes #104 I updated the ci.yml of the copier_template workflow to use pre-commit action itself. The template is not updated yet.

TODO:

[ ] Install pre-commit action in repositories (including copier_template)
[x] Add pre-commit action in template ci recipes

It was tested with essnmx: https://github.com/scipp/essnmx/pull/12.

SimonHeybrock commented 7 months ago

What is the status here? @jl-wynen, you opened #104 so maybe you are best as a reviewer.

YooSunYoung commented 7 months ago

@SimonHeybrock Just need to check if Install pre-commit action in repositories (including copier_template) is done...!

jl-wynen commented 7 months ago

What is the status here? @jl-wynen, you opened https://github.com/scipp/copier_template/issues/104 so maybe you are best as a reviewer

What @YooSunYoung said. As far as I'm concerned, we should switch to this action. I just installed the application in this repo. I'm happy to do it for all repos but I didn't want to do it without an explicit 'go ahead'.