search

scipp / copier_template

Copier template for Scipp projects
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Remove obsolete static tox env #150

Closed jl-wynen closed 2 months ago

jl-wynen commented 3 months ago

We run static analysis via the pre-commit action now. So we no longer need the static tox env.

jl-wynen commented 3 months ago

It seems like there is no way to run the action in a different repo / directory like I initially tried. So I reverted the change partially to still use a tox env for checking the rendered test project in CI.

jl-wynen commented 3 months ago

Ok, this doesn't actually work the way I imagined it. We can't run the action in a different directory. So we need to have a way of installing the 'correct' pre-commit version in the test project (from its requirements / workflow files). But that pretty much needs the current mechanism with tox -e static.

Should I just close this PR and we accept that we have multiple ways of calling pre-commit?