search

scipp / copier_template

Copier template for Scipp projects
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Use `conda-verify`? #41

Open SimonHeybrock opened 11 months ago

SimonHeybrock commented 11 months ago

We have this warning in package builds:

Importing conda-verify failed.  Please be sure to test your packages.  conda install conda-verify to make this message go away.

Should we fix that?

jl-wynen commented 11 months ago

Sure, let's try it out!

jl-wynen commented 10 months ago

Tried it and it emits a single warning:

/tmp/tmpnf0srwsm/proj-23.11.0-py_0.tar.bz2: C1115 Found invalid license "BSD-3-Clause" in info/index.json

According to https://github.com/conda/conda-verify/blob/3b34286470dd1ceb495374e3ff7b52082084da8e/conda_verify/constants.py#L8 it only wants "BSD" as the license. But in practice we haven't encountered any problems with this. So I don't know if we should change it.

In any case, I tried changing it and the warning went away. I also added license_file in my test like this: (in meta.yaml)

about:
  home: https://github.com/scipp/proj
  license: BSD
  license_file: LICENSE
  summary: testing
  description: testing
  dev_url: https://github.com/scipp/proj
  doc_url: https://scipp.github.io/proj