search

scipp / copier_template

Copier template for Scipp projects
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Fix namespace package #90

Closed SimonHeybrock closed 7 months ago

SimonHeybrock commented 7 months ago

Fixes #89

YooSunYoung commented 7 months ago

Oh.. it seems like removeprefix didn't work...?

SimonHeybrock commented 7 months ago

Yes, it needs Python 3.9. Oddly, it was already used by @jl-wynen in #44, not sure how that passed?

We can either move to 3.9, or try and find a different solution.

YooSunYoung commented 7 months ago

Yes, it needs Python 3.9. Oddly, it was already used by @jl-wynen in #44, not sure how that passed?

We can either move to 3.9, or try and find a different solution.

I think it's because the default answers for testing don't use namespace package... Is it possible to have multiple python versions installed in the CI environment...? then we can use copier with python 3.9 and test with python 3.8

SimonHeybrock commented 7 months ago

Or move CI to 3.9, since we plan to drop that in projects soon anyway?

YooSunYoung commented 7 months ago

Or move CI to 3.9, since we plan to drop that in projects soon anyway?

I just opened the PR to do so in #91.

SimonHeybrock commented 7 months ago

~I did it slightly different, to ensure that 3.8 still works for runtime.~ Reverted, I merged @YooSunYoung suggestion.