Updating the amor documentation plotting to use plopp

scipp / ess

European Spallation Source facility bespoke, neutron scattering tools based on scipp.

https://scipp.github.io/ess/

BSD 3-Clause "New" or "Revised" License

3 stars 3 forks source link

Updating the amor documentation plotting to use plopp #143

Closed arm61 closed 1 year ago

arm61 commented 1 year ago

As in the title. Note that I have removed the instrument view. I plan to replace this with a plot of the logical x- and y-dimensions summed along z once https://github.com/scipp/ess/pull/139 is merged.

arm61 commented 1 year ago

Okay I can't work out what I am doing wrong to add plopp to the repo...

nvaytet commented 1 year ago

Okay I can't work out what I am doing wrong to add plopp to the repo...

I got a passing build by moving plopp into the conda deps, but as far as I can tell, it should have worked in pip as well. I think just re-running the workflow with your last commit would have worked,

In any case, putting plopp alongside scipp, and scippneutron makes more sense I think.

arm61 commented 1 year ago

Awesome cheers! These isn’t a lot of changes in this commit but more to come hopefully.