Formatted the notebook with black and isort.
I didn't touch the text.
Are you using pre-commit? If not, you should enable it! It caught some spelling errors on my side. And it would stop you from uploading notebooks with outputs.
Some comments/questions:
What is header.reduction.script supposed to contain? As it stands it has a path on your machine that won't work for anyone else.
As we discussed, it makes sense to put the ORSO construction from a SciCat dataset into a function. Can you do this?
Should the monitor background subtraction use sample_mon_wav["wavelength", 15 * sc.units.angstrom:] instead of only the point at 15Å?
For later: many cells apply the same operations to the sample and direct beam data/monitors. Those two could be put into a data group which would allow you to map the operations over both. Then, you would not have to repeat the parameters.
Formatted the notebook with black and isort. I didn't touch the text.
Are you using pre-commit? If not, you should enable it! It caught some spelling errors on my side. And it would stop you from uploading notebooks with outputs.
Some comments/questions:
header.reduction.scriptsupposed to contain? As it stands it has a path on your machine that won't work for anyone else.sample_mon_wav["wavelength", 15 * sc.units.angstrom:]instead of only the point at 15Å?