search

scipp / ess

European Spallation Source facility bespoke, neutron scattering tools based on scipp.
https://scipp.github.io/ess/
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Ditch mantid from CI #208

Closed jl-wynen closed 1 year ago

jl-wynen commented 1 year ago

Given the struggle in #206 and that I need Scipp 23.08.0 for #203, this PR removes Mantid from the CI builds.

There still are calls to scn.load in the loki and imaging modules. But they import Mantid only when called. And they don't seem to get called anywhere.

jl-wynen commented 1 year ago

I suppose this opens the way to remove conda from the CI (and thus a bunch of env files)? But I suppose this should be done separately, and only after we know if it is worth it (given that we are extracting technique-packages).

Yes, should be done separately, if at all. We may need Mantid for some sub packages it switching away from conda would make that harder in the future.