search

scipp / ess

European Spallation Source facility bespoke, neutron scattering tools based on scipp.
https://scipp.github.io/ess/
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Update for next scipp #214

Closed jl-wynen closed 10 months ago

jl-wynen commented 10 months ago

sans2d_reduction.ipynb uses attrs explicitly in the notebook:

monitors = {}
for key, da in dg.items():
    monitors[f'{key}-incident'] = da.attrs["monitor2"].value
    monitors[f'{key}-transmission'] = da.attrs["monitor4"].value

I did not change this yet as it requires changing the data file. Since this is being migrated into esssans anyway, I don't see a reason for updating it here.

The reflectometry notebooks store 'orso' attributes. I also dind't change this as the solution would be inferior to what can be done in essreflectometry.

jl-wynen commented 10 months ago

Changed it to also work with scipp 23.07 like I did for scippneutron. This should allow us to continue using mantid in CI.