scipp / essnmx

Data reduction for NMX at the European Spallation Source
https://scipp.github.io/essnmx/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Handle banks via workflow graph instead of via extra dimension #49

Closed SimonHeybrock closed 5 months ago

SimonHeybrock commented 6 months ago

The current McStas loader loads all banks and concats the events, https://github.com/scipp/essnmx/blob/c5a2520e1ac6b209c855552729c6b0076abf4453/src/ess/nmx/mcstas_loader.py#L50-L60 subsequently folding after grouping by pixel https://github.com/scipp/essnmx/blob/c5a2520e1ac6b209c855552729c6b0076abf4453/src/ess/nmx/mcstas_loader.py#L134

YooSunYoung commented 6 months ago

Saving to NeXus may need to change slightly. Need to check with the IDS. I do not understand the current code, the panel dimension is first removed in

Yeah.. it's because what dials, the software that handles the next step, expects this as far as I understood...?