search

scipp / essnmx

Data reduction for NMX at the European Spallation Source
https://scipp.github.io/essnmx/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Deriving scale factor from reference bin. #55

Closed YooSunYoung closed 6 months ago

YooSunYoung commented 6 months ago

Related to #48

YooSunYoung commented 6 months ago

@jl-wynen It's still in-progress but can you please review this one as well...?

YooSunYoung commented 6 months ago

57 Also updates the helper functions in reduction.py,

so I would rather update it there instead of here...! Thanks!

YooSunYoung commented 6 months ago

I think the I column should just be the data and we don't need dummy_data. I'll reopen it agian after fixing it...!

YooSunYoung commented 6 months ago

So I fixed the data and the grouping methods. It's still a detouring grouping.

This requirement was requested for a while ago, so I would like to prioritize delivering this and we can fix the implementation detail later as mentioned in the comments.

I also tried making an integer coordinate combining all HKL, but it was much more tedious to implement than expected and I didn't want to put that much effort into a temporary solution... It's already fast enough now.

YooSunYoung commented 6 months ago

@SimonHeybrock I renamed them and updated the docstring as we discussed in the chat.