search

scipp / essnmx

Data reduction for NMX at the European Spallation Source
https://scipp.github.io/essnmx/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Allow both bin edges and number of bins in parameter `WavelengthBins` #67

Closed jokasimr closed 2 months ago

jokasimr commented 3 months ago

Was originally part of #66 but this change needs to wait for a sciline release.

YooSunYoung commented 3 months ago

https://github.com/scipp/essnmx/blob/02a577922fef46bb9b137f5d0e3f9b193985e656/requirements/base.txt#L82 It looks like the sciline version is not updated...! @jokasimr can you please update the requirements? I don't have access to a linux machine atm...

jokasimr commented 3 months ago

https://github.com/scipp/essnmx/blob/02a577922fef46bb9b137f5d0e3f9b193985e656/requirements/base.txt#L82

It looks like the sciline version is not updated...! @jokasimr can you please update the requirements? I don't have access to a linux machine atm...

No worries, I'll update the requirements before merging. But I'll wait for the sciline release. Or do you have another idea?

YooSunYoung commented 3 months ago

https://github.com/scipp/essnmx/blob/02a577922fef46bb9b137f5d0e3f9b193985e656/requirements/base.txt#L82

It looks like the sciline version is not updated...! @jokasimr can you please update the requirements? I don't have access to a linux machine atm...

No worries, I'll update the requirements before merging. But I'll wait for the sciline release. Or do you have another idea?

Ah ha...! I thought 24.4 was including the necessary change but apparently not... then it's fine, thanks!

jokasimr commented 2 months ago

Waiting for #73