search

scipp / essnmx

Data reduction for NMX at the European Spallation Source
https://scipp.github.io/essnmx/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Rotated detector pixel offset based on the starting position. #85

Closed YooSunYoung closed 2 months ago

YooSunYoung commented 2 months ago

We were assuming the first pixel is always at (0,0,0) but it was not the case.

I added this to be included.

I didn't clean up the code or write more tests because this geometry parsing will be obsolete soon.

jokasimr commented 2 months ago

@SimonHeybrock suggested merging this even if there are some question marks since it's mainly for testing anyway.

YooSunYoung commented 2 months ago

Are the position_offset vectors the offsets of the pixels from the origin of the detector coordinate system? In that case, should they not be rotated with the detector?

Yes. position_offset is not rotated.

Is the detector rotation matrix a rotation around the detectors own axis, or a rotation of the detector around the sample?

It's a rotation around the detector's own axis.