scipp / esspolarization

Polarization data reduction for the European Spallation Source
https://scipp.github.io/esspolarization/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Add methodology page to index, minor cleanup #32

Closed SimonHeybrock closed 5 months ago

SimonHeybrock commented 5 months ago

Anyhow, this is merged already. But what will be about the changes on the documentary regarding sigma_0 I have made last week? We think that no errorbar should be added.

Right, unfortunately GitHub does not manage to resolve the merge conflict automatically, so you will have to do it by hand (or copy your changes to the moved document).

We think that no errorbar should be added.

Shouldn't we add least add one that reflects the number of digits we know?

astellhorn commented 5 months ago

Right, unfortunately GitHub does not manage to resolve the merge conflict automatically, so you will have to do it by hand (or copy your changes to the moved document).

So I again add all changes I made last week to the renamed document in the current main?

astellhorn commented 5 months ago

Shouldn't we add least add one that reflects the number of digits we know?

Hm, that might confuse readers? Cause then theyd expect we have this errorbar measured or some more deeper reason to apply it?

SimonHeybrock commented 5 months ago

Shouldn't we add least add one that reflects the number of digits we know?

Hm, that might confuse readers? Cause then theyd expect we have this errorbar measured or some more deeper reason to apply it?

Isn't it more important to get the correct error bars on the final result? We should not just ignore sources of uncertainty, I suppose?

SimonHeybrock commented 5 months ago

Right, unfortunately GitHub does not manage to resolve the merge conflict automatically, so you will have to do it by hand (or copy your changes to the moved document).

So I again add all changes I made last week to the renamed document in the current main?

Yes, sorry about that, I did not notice that there were concurrent changes to the same file. Is it many changes?

astellhorn commented 5 months ago

Isn't it more important to get the correct error bars on the final result? We should not just ignore sources of uncertainty, I suppose?

Sure, but it will be the lowest contributing part of the whole workflow - and as I do not find a listed error bar for this exact value, I am unsure to which preciseness it is measured. It is fine with me to just add an artificial errorbar according to the unit we are referring to, i.e., plus/minus 1 barn if the value is 2966 barn.

astellhorn commented 5 months ago

Right, unfortunately GitHub does not manage to resolve the merge conflict automatically, so you will have to do it by hand (or copy your changes to the moved document).

So I again add all changes I made last week to the renamed document in the current main?

Yes, sorry about that, I did not notice that there were concurrent changes to the same file. Is it many changes?

No worries, I will just look up what it was! Just a bit of text