scipp / esspolarization

Polarization data reduction for the European Spallation Source
https://scipp.github.io/esspolarization/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Supermirror, flipper matrices, and workflow with configurable polarizer/analyzer #60

Closed SimonHeybrock closed 3 weeks ago

SimonHeybrock commented 1 month ago

This adds:

Fixes #59.

jokasimr commented 1 month ago

It's hard to review this without a description of the procedure. I did not find anything out flippers in the polarization analysis methodology page. What source did you use to implement this @SimonHeybrock?

SimonHeybrock commented 1 month ago

It's hard to review this without a description of the procedure. I did not find anything out flippers in the polarization analysis methodology page. What source did you use to implement this @SimonHeybrock?

@astellhorn was adding information in #56, but I think a file was missing and the PR needs updating. Otherwise, have a look at the attachments in https://github.com/scipp/esspolarization/issues/2#issuecomment-1833647206 (probably not most recent version).

astellhorn commented 4 weeks ago

It's hard to review this without a description of the procedure. I did not find anything out flippers in the polarization analysis methodology page. What source did you use to implement this @SimonHeybrock?

@astellhorn was adding information in #56, but I think a file was missing and the PR needs updating. Otherwise, have a look at the attachments in #2 (comment) (probably not most recent version).

Yes, I forgot to add the new methodology file into the branch, and will update it (best today, but I am on a conference since sunday up to tomorrow, but will have some time today lunch break).

astellhorn commented 4 weeks ago

now it is under esspolarization/docs

/user-guide/

--> see file General-sans-polarization-analysis-methodology.ipynb --> there will probably be some small changes needed again