Closed jl-wynen closed 5 months ago
ORSO also allows specifying the machine that the software runs on and the old code used this: https://github.com/scipp/ess/blob/5372ef6e91f2ee8bf4903c3db081b949e76952fd/src/ess/amor/orso.py#L47 I omitted this here because storing a user computer's name doesn't help much and seems like exposing private information. What do you think @jokasimr ?
ORSO also allows specifying the machine that the software runs on and the old code used this: https://github.com/scipp/ess/blob/5372ef6e91f2ee8bf4903c3db081b949e76952fd/src/ess/amor/orso.py#L47 I omitted this here because storing a user computer's name doesn't help much and seems like exposing private information. What do you think @jokasimr ?
Yes I noticed that as well. It seems unnecessary.
It is now complete except for listing corrections.
We still need to figure out how do do that. The approach with tags that I outlined in the issue #6 will stop working when https://github.com/scipp/sciline/pull/116 is merged.
I forgot to add tests. Did that now
~Fixes #6~ Most of #6 except tracking corrections.
This is still missing saving the actual data, tracking 'corrections', and filling in the remaining 'instrument' data. But it implements the basic mechanism and this part is ready for review.
For reference, adding it to the default pipeline like this:
results in
With this graph:![Screenshot_20240202_155917](https://github.com/scipp/essreflectometry/assets/11393224/894e9120-6ba1-4f96-91dc-c6a628b3463c)